Fix how TestForceNewCluster checks if a service is ready #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck only the tasks related to that service and to check if the number of running tasks for that service = the number of desired tasks. Signed-off-by: cyli <[email protected]>
cyli
force-pushed
the
fix-force-new-cluster
branch
from
4909303 to
eca7b97
Compare
Codecov Report@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
+ Coverage 54.15% 54.16% +<.01%
==========================================
Files 108 106 -2
Lines 18544 18460 -84
==========================================
- Hits 10042 9998 -44
+ Misses 7284 7238 -46
- Partials 1218 1224 +6Continue to review full report at Codecov.
|
|
Let's merge this one first. LGTM ping @LK4D4 |
cyli
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually fix the flakey test yet - the
pollServiceReadyfunction is checking for all tasks on the node, instead of only the running tasks for that particular service, which masks the returned error.The underlying cause is being fixed by @aaronlehmann in another PR.