-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: OTEL v0.46.1 / v1.21.0 #47245
Conversation
Looks like this needs some local changes (either temporary
|
Signed-off-by: Sebastiaan van Stijn <[email protected]>
grpc.WithUnaryInterceptor(otelgrpc.UnaryClientInterceptor()), //nolint:staticcheck // TODO(thaJeztah): ignore SA1019 for deprecated options: see https://github.com/moby/moby/issues/47437 | ||
grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor()), //nolint:staticcheck // TODO(thaJeztah): ignore SA1019 for deprecated options: see https://github.com/moby/moby/issues/47437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion on Slack, I added some nolint tags for now, and created a tracking ticket to update this code; #47437
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let me bring this one in, so that we can rebase the BuildKit update. The PR on the BuildKit side is not needed for this to work (we just used that also to verify on both sides) |
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)