update to go 1.17 as minimum, fix and update actions #30
Conversation
|
|
||
| require ( | ||
| github.com/sirupsen/logrus v1.4.2 | ||
| github.com/vishvananda/netlink v1.1.0 | ||
| github.com/vishvananda/netns v0.0.0-20191106174202-0a2b9b5464df | ||
| golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527 | ||
| ) | ||
|
|
||
| require github.com/konsorten/go-windows-terminal-sequences v1.0.1 // indirect |
There was a problem hiding this comment.
I think this indirect should go away if we update the minimum logrus version
thaJeztah
force-pushed
the
update_go_versions
branch
2 times, most recently
from
8e33f5a to
a52c56e
Compare
thaJeztah
force-pushed
the
update_go_versions
branch
4 times, most recently
from
cbdcafe to
2c17e23
Compare
|
Next up, after #31 was merged |
| - name: Ensure IPVS module | ||
| run: sudo modprobe ip_vs | ||
| run: | |
There was a problem hiding this comment.
I don't think there's a need for the multiline string syntax when we only have one line
There was a problem hiding this comment.
Ah, yeah, I made the change as I was syncing with other repositories (made it easier to compare).
Happy to revert if you prefer though (let me know)
There was a problem hiding this comment.
That justification makes sense; ultimately using composite actions among the repos that are very similar (e.g. these small modules) is probably something we should explore.
committed the result of:
go mod tidy -go=1.17 -compat=1.13
Signed-off-by: Sebastiaan van Stijn <[email protected]>
- update go versions to go1.17, and latest (1.19.x) - fix incorrect `go-versions` (plural) in the matrix, and rename "platform" to "os" (which looks to be what we use elsewhere) - update github action versions - set permissions and timeout for github actions - switch to use the golangci-lint action (instead of using a container) - update golangci-lint to 1.50.1, which is needed for compatibility with current go versions - replace "golint" with "revive" as golint is deprecated. - update how we use `sudo` for testing (see [this tweet][1]) - add a go mod tidy check [1]: https://twitter.com/kolyshkin/status/1367697997979557897 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_go_versions
branch
from
2c17e23 to
9b4cd23
Compare
Ah, yes, can do! Updated 👍 |
changes in this PR:
go-versions(plural) in the matrix, and rename "platform" to "os" (which looks to be what we use elsewhere)sudofor testing (see this tweet)