dockerfile: avoid too eager loading of unreachable named contextes #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
dockerfile-eager-ncontext
branch
from
67b76cb to
4190572
Compare
3 tasks
cpuguy83
approved these changes
Jan 31, 2025
AkihiroSuda
reviewed
Feb 4, 2025
| @@ -9167,6 +9168,49 @@ func testSourcePolicyWithNamedContext(t *testing.T, sb integration.Sandbox) { | |||
| require.Equal(t, "foo", string(dt)) | |||
| } | |||
|
|
|||
| func testEagerNamedContextLookup(t *testing.T, sb integration.Sandbox) { | |||
There was a problem hiding this comment.
Maybe add a comment to explain "eager"
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
dockerfile-eager-ncontext
branch
from
4190572 to
d394e48
Compare
AkihiroSuda
approved these changes
Feb 7, 2025
crazy-max
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes docker/buildx#2939
Avoids pulling in a named context if the build dependencies are not actually using it. The main case where this issue appears is when image is used as a named context and image config would be resolved. In addition to wasting resources, the image could also be invalid for the current build configuration and cause the build to fail.