integration: log goroutine trace on test timeout #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
intergration-test-timeout-traces
branch
from
f054ad5 to
ca6fa29
Compare
tonistiigi
force-pushed
the
intergration-test-timeout-traces
branch
from
ca6fa29 to
47642a2
Compare
Add maximum timeout to each test and log all buildkitd goroutines when a test gets stuck. Currently tests can time out and will print daemon logs but these would already be after shutdown signal is sent to the daemon. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
intergration-test-timeout-traces
branch
from
47642a2 to
58b5e6a
Compare
crazy-max
approved these changes
Dec 5, 2024
crazy-max
reviewed
Dec 5, 2024
| @@ -18,6 +22,8 @@ import ( | |||
|
|
|||
| const buildkitdConfigFile = "buildkitd.toml" | |||
|
|
|||
| const maxSandboxTimeout = 5 * time.Minute | |||
There was a problem hiding this comment.
5min might not be enough for this test TestIntegration/TestBasicGhaCacheImportExport: https://github.com/moby/buildkit/actions/runs/12189447998/job/34004770018?pr=5568#step:8:2218
Default timeout is 10m:
buildkit/cache/remotecache/gha/gha.go
Line 44 in 409f7b4
There was a problem hiding this comment.
Added extra time to GHA test
This test can hit rate-limiting from Github and run long. Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maximum timeout to each test and log all buildkitd
goroutines when a test gets stuck. Currently tests can time out
and will print daemon logs but these would already be after
shutdown signal is sent to the daemon.
Is there any other runtime info that is also worth printing?
Test with fake deadlock: