http: avoid possible digest mismatch error #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
approved these changes
Sep 24, 2024
crazy-max
requested changes
Oct 1, 2024
There is a possibility to get a digest mismatch error if the metadata for previous download does not point to a valid reference anymore. To mitigate this, check that ref that etag points to is still valid before using it. Additionally `.cacheKey` property was not previously set in the cases where old reference was reused. This caused a case where even if the download needed to be performed again, it always failed validation, even if the digest had not actually changed since previous download. There is still a small possibility that gc/prune request will delete the downloaded record in between cachemap and exec call and that the contents changes in the server at that exact time. To fix that case we would need to modify cachemap so that it can keep hold of references until build is complete. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
http-digest-mismatch
branch
from
415f934 to
3b35fc3
Compare
crazy-max
approved these changes
Oct 5, 2024
jedevc
pushed a commit
to jedevc/buildkit
that referenced
this pull request
Oct 10, 2024
http: avoid possible digest mismatch error (cherry picked from commit 8c313f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility to get a digest mismatch error if the metadata for previous download does not point to a valid reference anymore.
To mitigate this, check that ref that etag points to is still valid before using it.
Additionally
.cacheKeyproperty was not previously set in the cases where the old reference was reused. This caused a case where even if the download needed to be performed again, it always failed validation, even if the digest had not actually changed since the previous download.There is still a small possibility that gc/prune request will delete the downloaded record in between cachemap and exec call and that the contents changes in the server at that exact time. To fix that case, we would need to modify cachemap so that it can keep hold of references until build is complete.
fixes #5020
cc @dnephin