-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gc policy for windows to use 20% of disk space #4865
Merged
AkihiroSuda
merged 1 commit into
moby:master
from
profnandaa:fix-buildx-2411-wcow-gcpolicy
Apr 23, 2024
Merged
fix: gc policy for windows to use 20% of disk space #4865
AkihiroSuda
merged 1 commit into
moby:master
from
profnandaa:fix-buildx-2411-wcow-gcpolicy
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
commented
Apr 22, 2024
jedevc
reviewed
Apr 22, 2024
tonistiigi
reviewed
Apr 22, 2024
61399b6
to
2b9917d
Compare
profnandaa
commented
Apr 22, 2024
tonistiigi
reviewed
Apr 22, 2024
d58718d
to
56d3745
Compare
jedevc
approved these changes
Apr 23, 2024
crazy-max
reviewed
Apr 23, 2024
crazy-max
approved these changes
Apr 23, 2024
tonistiigi
requested changes
Apr 23, 2024
56d3745
to
761cb10
Compare
tonistiigi
reviewed
Apr 23, 2024
Initially we had the GC Policy for Windows use only 2 GB (2e9 bytes) of disk space and this was limiting for some build scenarios that need more than that, especially ServerCore images. This commit makes the policy to use percentages as it is on Linux. Also going for 20%, double that of Linux, since Windows images tend to be larger. fixes moby#4858 docker/buildx#2411 Also, refactors the diskSize logic to simplify it by bringing the `d.AsByte` function back from platform specific files to `gcpolicy.go`. Signed-off-by: Anthony Nandaa <[email protected]>
761cb10
to
a5f9e42
Compare
tonistiigi
approved these changes
Apr 23, 2024
AkihiroSuda
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially we had the GC Policy for Windows use only 2 GB (2e9 bytes) of disk space and this was limiting for some build scenarios that need more than that, especially ServerCore images.
This commit makes the policy to use percentages as it is on Linux. Also going for 20%, double for that on Linux, since Windows images are generally larger. For instance, after the change, on a dev machine, the configured space was
74694367232 / (1 << 30) = 69.5 GiB
.fixes #4858 docker/buildx#2411
Before:
After: