Introduce new attestation exporter options
#3403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
force-pushed
the
exporter-attestations-options
branch
from
de22d35 to
2aa3f8a
Compare
tonistiigi
reviewed
Dec 14, 2022
jedevc
force-pushed
the
exporter-attestations-options
branch
from
2aa3f8a to
fe28241
Compare
|
Removed inline-only in #3420 - we shouldn't block the rest of the changes on that. |
tonistiigi
reviewed
Dec 20, 2022
| } | ||
|
|
||
| for _, att := range attestations { | ||
| target, ok := att.Metadata[result.AttestationReasonKey] |
There was a problem hiding this comment.
Not from this PR but I don't understand why this is called a "reason". It is attestation type. So why can't we just use the already existing predicate type field?
Signed-off-by: Justin Chadwell <[email protected]>
This allows one implementation for all the opts parsing, similar to how we do today for the ImageCommitOpts. Additionally, we rename attestation-prefix to attestations-prefix (pluralized) to prepare for the new attestations option. Signed-off-by: Justin Chadwell <[email protected]>
This option looks like a mistake added in 45fc3ed. These options aren't ever used, so we don't need to parse them, we can just silently discard them. Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
Instead of just the boolean true/false values, we allow the attestation option for exporters to contain an arbitrary list of "attestation reasons". Only attestations that have a reason matching the list will actually be output. This allows clients to completely detach the concepts of "what attestations to generate" and "what attestations to output". Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
exporter-attestations-options
branch
from
fe28241 to
2488167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These replace the
inline-onlyattestation fields introduce in #3342.Instead, we can now specify
attestations=<true/false/filter-list>per exporter, to enable specific attestation per exporter - the default in buildkit is set totrue. The possible values are:true: output all provided attestations from the solverfalse: output none of the provided attestations from the solverreason,[reasons]: a csv list of reasons, outputs only the attestations that were generated for one of those specified reasons, using the metadata field. e.g.--output type=...,attestations=provenancewill only include provenance attestations in the output for that exporter, even if other attestations (like SBOMs) were generated in the solver.We also update the
attestation-prefixoption to beattestation[s]-prefix- to be more aligned with the newattestationsflag.Additionally, we have a few smaller minor refactoring commits around the exporter: