Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goto statements causing failed edges to never unpark #2556

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Remove goto statements causing failed edges to never unpark #2556

merged 1 commit into from
Jan 13, 2022

Conversation

hinshun
Copy link
Collaborator

@hinshun hinshun commented Jan 12, 2022

Fixes #2526

Though we still need to figure out how #2526 triggered markFailed in the first place.

@hinshun hinshun requested a review from tonistiigi January 12, 2022 23:53
@hinshun hinshun force-pushed the scheduler-inf-loop branch from e93e2b5 to 465a30a Compare January 12, 2022 23:59
@aaronlehmann
Copy link
Collaborator

Thanks!

@tonistiigi tonistiigi merged commit e5e39c3 into moby:master Jan 13, 2022
@griffous griffous mentioned this pull request Jan 17, 2022
Open
@crazy-max crazy-max added this to the v0.10.0 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Possible infinite loop in scheduler
4 participants
@hinshun @aaronlehmann @tonistiigi @crazy-max