Add systemd support for rootless buildkitd #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add systemd notify support, for both. Use proxy and access all, for rootlesskit. Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
reviewed
Nov 19, 2021
Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the unit start up faster and more reliable, using sd_notify:
https://www.freedesktop.org/software/systemd/man/systemd-notify.html
The file descriptors (3) are not passed on from rootlesskitd to buildkitd:
https://www.freedesktop.org/software/systemd/man/systemd-socket-proxyd.html
Also need to relax the pid checks, so that it accepts it not being the main:
buildkit.service: Got notification message from PID 211231, but reception only permitted for main PID 211211