add size to tmpfs mounts #2411
Merged
add size to tmpfs mounts #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Oct 13, 2021
|
Don't forget to add a capability for this. We may also need to make sure we deduplicate the mounts in executor so it is not inefficient by mounting twice if you overwrite default mountpoint. Unless we confirm that containerd/runc already does it but I think not. |
tonistiigi
reviewed
Oct 13, 2021
tonistiigi
reviewed
Oct 13, 2021
crazy-max
force-pushed
the
tpmfs-size
branch
4 times, most recently
from
82746f8 to
c6cae16
Compare
tonistiigi
reviewed
Oct 15, 2021
They are not indeed. Will add a dedup impl in spec. |
crazy-max
commented
Oct 17, 2021
crazy-max
force-pushed
the
tpmfs-size
branch
3 times, most recently
from
317702b to
f5f9a77
Compare
tonistiigi
reviewed
Oct 17, 2021
crazy-max
force-pushed
the
tpmfs-size
branch
2 times, most recently
from
c628459 to
459449d
Compare
tonistiigi
reviewed
Oct 18, 2021
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
tonistiigi
approved these changes
Oct 18, 2021
This was referenced Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up docker/buildx#790
Related to #2384
Change the shm-size implementation to instead add size to tmpfs mounts.
Signed-off-by: CrazyMax [email protected]