Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas.scaleFactor not take into account #15

Closed
soimy opened this issue Dec 8, 2018 · 6 comments
Closed

Canvas.scaleFactor not take into account #15

soimy opened this issue Dec 8, 2018 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@soimy
Copy link

soimy commented Dec 8, 2018

env: Unity 2018.2.17f1
When using Screen space - Overlay and UI scale Mode Scale with screen size, Canvas.scaleFactor should take into account inside UpdateMesh()

@mob-sakai mob-sakai added the bug Something isn't working label Dec 10, 2018
@mob-sakai
Copy link
Owner

mob-sakai commented Dec 10, 2018

Hi @soimy
Thank you for reporting!

@mob-sakai
Copy link
Owner

I will fix this issue in the next release.

Before:

After:

@mob-sakai mob-sakai changed the title v1.1.0 Canvas.scaleFactor not take into account Canvas.scaleFactor not take into account Dec 10, 2018
@mob-sakai
Copy link
Owner

Sorry.
The fix seems not to be enough.

@mob-sakai mob-sakai reopened this Dec 11, 2018
@mob-sakai
Copy link
Owner

When I test it, it does not work well if ParticleSystem.ScalingMode is set to ”Hierarchy".
This is because it is affected by the scale of Canvas.

@mob-sakai
Copy link
Owner

mob-sakai commented Dec 12, 2018

I found a way to scale well in most cases!

  • All ParticleSystem.ScalingModes are supported
  • All Canvas.RenderModes are supported

It scales well even if you change the following parameters:

  • Camera.FieldOfView
  • CanvasScaler.MatchWidthOrHeight
  • Canvas.PlaneDistance

@mob-sakai
Copy link
Owner

The issue will be fixed in the next release:)

@mob-sakai mob-sakai added this to the v1.2.0 milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants