Keyboard #1060
Merged
Keyboard #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make key events from all hosts compatible. Also did some refactoring. Also removed AKUEnqueueKeyboard*Event functions that are now superfluous
Existing text input code relied on knowing the layout of US keyboards and didn't work on non-US keyboards. Now there's a dedicated keyboard event that delivers UTF-8-encoded characters on any keyboard.
Made sure the Chrome host compiles. It will still send incorrect key codes, though. See code comment.
|
Rest looks good. Since this is a change of feature instead of new functionality or bug fixes, I think I will let @patrickmeehan merge it but LGTM 👍 Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings much more robust keyboard handling.
if key == 338, you can now writeif key == MOAIKeyCode.UPand be sure it'll work on all hosts and platforms with keyboard support. Before, that key produced 38 using the HTML host, 338 using SDL, and didn't work at all using GLUT on Windows.samples/input-textthat shows a fully editable textbox, complete with cursor navigation. It works on any keyboard layout and is fully Unicode-compatible.This pull request is based on this forum discussion: [WIP CONTRIB] Proposal for robust keyboard handling.