-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filters to a stream object #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsoner To complete the short discussion on the issue, could you have a quick look through this PR, especially through the 2 comments I left?
I'm not convince the initial condition zi
stay valid if multiple filters are applied one by one to the same channel. Maybe I need to write some code to combine the filters applied to the same channel and thus prevent any overlap in the picks
associated with each filter.
After a good night of sleep, I'm actually convince that the initial conditions are not valid anymore. I don't see an easy way to set dynamically the |
Closes #105
Remaining TODOs:
Stream
objectStream.filter(...)