remove all TODO comments

mnaamani · Apr 8, 2024 · 0495627 · 0495627
1 parent d8b770e
commit 0495627
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 15 deletions.
diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
@@ -867,7 +867,6 @@ parameter_types! {
         DefaultStorageDepositCleanupProfit::get()
     );
 
-    // TODO: Adjust those?
     pub const MaxNumberOfAssetsPerChannel: MaxNumber = 10;
     pub const MaxNumberOfAssetsPerVideo: MaxNumber = 20;
     pub const MaxNumberOfCollaboratorsPerChannel: MaxNumber = 10;
@@ -1121,11 +1120,11 @@ parameter_types! {
     pub const MaxDistributionBucketFamilyNumber: u64 = 200;
     pub const BlacklistSizeLimit: u64 = 1_000;
     pub const MaxNumberOfPendingInvitationsPerDistributionBucket: u32 = 20;
-    pub const StorageModuleId: PalletId = PalletId(*b"mstorage"); // module storage
+    pub const StorageModuleId: PalletId = PalletId(*b"mstorage");
     pub const MinDistributionBucketsPerBag: u32 = 1;
     pub const MaxDistributionBucketsPerBag: u32 = 51;
     pub const MaxDataObjectSize: u64 = giga_bytes!(60);
-    pub const MaxNumberOfOperatorsPerDistributionBucket: u32 = 20; // TODO: adjust value
+    pub const MaxNumberOfOperatorsPerDistributionBucket: u32 = 20;
 
     // Data object bloat bond related:
     // To calculate the cost of removing a data object we substract the cost of removing a video
@@ -1281,9 +1280,9 @@ parameter_types! {
         FroumPostCleanupTxFee::get(),
         DefaultStorageDepositCleanupProfit::get()
     );
-    pub const ForumModuleId: PalletId = PalletId(*b"mo:forum"); // module : forum
+    pub const ForumModuleId: PalletId = PalletId(*b"mo:forum");
     pub const PostLifeTime: BlockNumber = days!(30);
-    pub const MaxStickiedThreads: u32 = 20; // TODO: adjust
+    pub const MaxStickiedThreads: u32 = 20;
 }
 
 pub struct MapLimits;
@@ -1365,7 +1364,6 @@ parameter_types! {
     pub const MinimumApplicationStake: Balance = dollars!(20);
     // This should be more costly than `add_opening` fee
     pub const LeaderOpeningStake: Balance = dollars!(100);
-    pub const WorkingGroupModuleId: PalletId = PalletId(*b"mworking"); // module storage
 }
 
 // Make sure that one cannot leave before a slashing proposal for lead can go through.

diff --git a/runtime/src/proposals_configuration/defaults.rs b/runtime/src/proposals_configuration/defaults.rs
@@ -171,7 +171,6 @@ pub(crate) fn terminate_working_group_lead_proposal() -> ProposalParameters<Bloc
 }
 
 // Proposal parameters for the 'Amend Constitution' proposal
-// TODO: To be removed
 pub(crate) fn amend_constitution_proposal() -> ProposalParameters<BlockNumber, Balance> {
     ProposalParameters {
         voting_period: 72200,
@@ -373,7 +372,6 @@ pub(crate) fn freeze_pallet_proposal() -> ProposalParameters<BlockNumber, Balanc
     }
 }
 
-// TODO (luxor/reward-curve-proposal): adjust parameters
 // Proposal parameters for the 'Set Era Payout Damping Factor' proposal
 pub(crate) fn set_era_payout_damping_factor() -> ProposalParameters<BlockNumber, Balance> {
     ProposalParameters {

diff --git a/runtime/src/proposals_configuration/staging.rs b/runtime/src/proposals_configuration/staging.rs
@@ -171,7 +171,6 @@ pub(crate) fn terminate_working_group_lead_proposal() -> ProposalParameters<Bloc
 }
 
 // Proposal parameters for the 'Amend Constitution' proposal
-// TODO: To be removed
 pub(crate) fn amend_constitution_proposal() -> ProposalParameters<BlockNumber, Balance> {
     ProposalParameters {
         voting_period: minutes!(20),
@@ -372,7 +371,6 @@ pub(crate) fn update_token_pallet_token_governance_parameters(
     }
 }
 
-// TODO (luxor/reward-curve-proposal): adjust parameters
 // Proposal parameters for the 'Set Era Payout Damping Factor' proposal
 pub(crate) fn set_era_payout_damping_factor() -> ProposalParameters<BlockNumber, Balance> {
     ProposalParameters {

diff --git a/runtime/src/proposals_configuration/testing.rs b/runtime/src/proposals_configuration/testing.rs
@@ -361,7 +361,6 @@ pub(crate) fn update_token_pallet_token_governance_parameters(
     }
 }
 
-// TODO (luxor/reward-curve-proposal): adjust parameters
 // Proposal parameters for the 'Set Era Payout Damping Factor' proposal
 pub(crate) fn set_era_payout_damping_factor() -> ProposalParameters<BlockNumber, Balance> {
     ProposalParameters {

diff --git a/runtime/src/runtime_api.rs b/runtime/src/runtime_api.rs
@@ -71,7 +71,7 @@ impl OnRuntimeUpgrade for CancelActiveAndPendingProposals {
     fn on_runtime_upgrade() -> Weight {
         ProposalsEngine::cancel_active_and_pending_proposals();
 
-        Weight::from_parts(10_000_000, 0) // TODO: adjust weight
+        Weight::from_parts(10_000_000, 0)
     }
 }
 

diff --git a/runtime/src/tests/proposals_integration/mod.rs b/runtime/src/tests/proposals_integration/mod.rs
@@ -696,7 +696,6 @@ fn veto_proposal_proposal_execution_succeeds() {
     });
 }
 
-// TODO:
 // We ignore this test because it needs to be re-written to take into account
 // that constitutionality > 1
 #[ignore]
@@ -983,7 +982,6 @@ fn set_referral_cut_proposal_succeeds() {
     });
 }
 
-// TODO:
 // We ignore this test because it needs to be re-written to take into account
 // that constitutionality > 1
 #[ignore]
@@ -1025,7 +1023,6 @@ fn set_budget_increment_proposal_succeds() {
     });
 }
 
-// TODO:
 // We ignore this test because it needs to be re-written to take into account
 // that constitutionality > 1
 #[ignore]