-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing MMTK_MIN_HSIZE_G
and MMTK_MAX_HSIZE_G
from CI
#224
Conversation
… heap collections)
julia-version |
MMTK_MIN_HSIZE_G
and MMTK_MAX_HSIZE_G
MMTK_MIN_HSIZE_G
and MMTK_MAX_HSIZE_G
from CI
I don't know if we want to do this change. There seems no benifit of removing the specified heap size. |
I was just curious to see if the CI will run without it. At the same time, the semantics for the heap size environment variables is now a bit unclear. Do we want to use them with membalancer or use the stock heuristics? Should we support both? Or should we keep everything as it is and only use those for membalancer, using |
This is the exact reason that I think we should not remove the heap size -- we no longer know if we can run the tests. It would highly depend on the machine we run it. Also if a test fail in CI, it would be harder to reproduce it locally, as the heap size would be different.
We can get this right. If Julia allows us to specify heap size, we should be compatible with whatever Julia provides. If Julia does not allow it, we need our own way to do that. |
Closed but opened an issue to keep track and implement a proper solution in the future. |
This PR is the same as #222 but it removes
MMTK_MIN_HSIZE_G
andMMTK_MAX_HSIZE_G
from our CI configuration, using the default values from the Stock GC.It works as a check to see if we still need to specify those values with the stock GC heuristics because of the specs from the github runner.