Remove transitive pinning of global_roots_table #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
reviewed
Aug 30, 2024
qinsoon
force-pushed
the
pin-globally-rooted-symbols
branch
from
3e3796c to
a9afe84
Compare
This makes changes for upstream API changes. Upstream PR: mmtk/mmtk-core#1195 --------- Co-authored-by: mmtkgc-bot <[email protected]>
qinsoon
changed the title
udesou
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
I think the code looks good, but you might want to include in the PR description what you had to do in terms of pinning (pinning objects and dealing with internal pointers) just to keep track of what has changed. I think that it is a consequence of getting rid of the transitive pinning of the global_roots_table, so the title is fine, but in the description you only mention the changes to the global variables.
qinsoon
added a commit
to mmtk/julia
that referenced
this pull request
Oct 11, 2024
This PR adds a few more pining for types in the native heap, and exposes globally rooted symbols so we can trace them in the MMTk binding. With this PR, we can run moving Immix without transitively pinning `global_roots_table`. See mmtk/mmtk-julia#170. * Add `jl_gc_pin` * Use `jl_gc_pin` to pin `BigFloat` for MPFR * Rename `PTR_PIN` to `OBJ_PIN`. Additionally add `PTR_PIN` which handles cases for internal pointers. * Pin objects that are used as key in `jl_codectx_t.global_targets` * Pin objects that are stored in `jl_codectx_t.PhiNodes` * Pin objects that are referred to by `jl_cgval_t` * Disable GC before doing perm alloc in `jl_get_layout` (see mmtk/mmtk-julia#172) * Pin weak references and the referee (see mmtk/mmtk-julia#176) * Pin objects that are used in `libuv`'s handle. * Pin `jl_task_t.completion_future` (see mmtk/mmtk-julia#179) * Pin all `jl_codeinst_t` objects. * Pin all `jl_method_instance_t` objects. * Pin all `jl_module_t` objects. * Pin all `jl_task_t` objects. * Expose some `JL_GLOBALLY_ROOTED` symbols, such as `newly_inferred`, `task_done_hook_func`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the transitive pinning of global_roots_table. To be specific, this PR
JL_GLOBALLY_ROOTEDsymbol as a root (trace and not move them).mmtk_jl_task_stack_buffer.