Check with is_in_mmtk_spaces instead of is_mapped_address #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
added
the
backport-v1.9.2+RAI
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Objects in VM spaces are not 'mmapped' by MMTk, so `is_mapepd_address` will return `false` for those. But they are still considered as in MMTk spaces (the VM space). Note that malloc'd objects are not mapped by MMTk, and not in MMTk spaces, so both methods will return `false` for malloc'd objects. However, this seems irrelevant in this scan object code. (cherry picked from commit 6f38359)
qinsoon
added a commit
that referenced
this pull request
Jan 29, 2024
) (#124) This is an automatic backport of pull request #123 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Yi Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects in VM spaces are not 'mmapped' by MMTk, so
is_mapepd_addresswill returnfalsefor those. But they are still considered as in MMTk spaces (the VM space).Note that malloc'd objects are not mapped by MMTk, and not in MMTk spaces, so both methods will return
falsefor malloc'd objects. However, this seems irrelevant in this scan object code.