Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon color: bluesky, instagram, threads, tiktok, x, youtube #5103

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

icon color: bluesky, instagram, threads, tiktok, x, youtube #5103

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
616a6ff
icon color: bluesky, instagram, threads, tiktok, x, youtube
codelabor Jan 27, 2025
7fb3567
toc label korean
codelabor Jan 27, 2025
a075f0f
Modifying awkward expressions
codelabor Jan 27, 2025
0133857
height alignment of toc and h2 does not match when using aside
codelabor Jan 27, 2025
a322c4a
add if condition for author urls wrapper
codelabor Jan 28, 2025
80e6d0f
Revert "height alignment of toc and h2 does not match when using aside"
codelabor Jan 31, 2025
1c70fd2
Revert "height alignment of toc and h2 does not match when using aside"
codelabor Jan 31, 2025
14d71a7
vertical alignment for first content
codelabor Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions _data/ui-text.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,11 +601,11 @@ ko: &DEFAULT_KO
page : "페이지"
pagination_previous : "이전"
pagination_next : "다음"
breadcrumb_home_label : "Home"
breadcrumb_home_label : "홈"
breadcrumb_separator : "/"
menu_label : "토글 메뉴"
search_label :
toc_label : "On This Page"
toc_label : "목차"
ext_link_label : "직접 링크"
less_than : "최대"
minute_read : "분 소요"
Expand All @@ -614,17 +614,17 @@ ko: &DEFAULT_KO
tags_label : "태그:"
categories_label : "카테고리:"
date_label : "업데이트:"
comments_label : "댓글남기기"
comments_label : "댓글 남기기"
comments_title : "댓글"
more_label : "더 보기"
related_label : "참고"
follow_label : "팔로우:"
feed_label : "피드"
powered_by : "Powered by"
powered_by : "제작 지원: "
website_label : "웹사이트"
email_label : "이메일"
recent_posts : "최근 포스트"
undefined_wpm : "Undefined parameter words_per_minute at _config.yml"
undefined_wpm : "_config.yml 파일에 words_per_minute 값이 설정되어 있지 않습니다."
comment_form_info : "이메일은 공개되지 않습니다. 작성 필요 필드:"
comment_form_comment_label : "댓글"
comment_form_md_info : "마크다운을 지원합니다."
Expand All @@ -633,11 +633,11 @@ ko: &DEFAULT_KO
comment_form_website_label : "웹사이트(선택사항)"
comment_btn_submit : "댓글 등록"
comment_btn_submitted : "등록됨"
comment_success_msg : "감사합니다! 댓글이 머지된 후 확인하실 수 있습니다."
comment_error_msg : "댓글 등록에 문제가 있습니다. 필요 필드를 작성했는지 확인하고 다시 시도하세요."
loading_label : "로딩중..."
comment_success_msg : "댓글이 등록되었습니다. 등록된 내용은 관리자 승인 후에 표시됩니다."
comment_error_msg : "댓글이 등록되지 않았습니다. 필수 입력 항목이 빠졌는지 확인하고 다시 시도하세요."
loading_label : "로딩 중..."
search_label_text :
search_placeholder_text : "검색어를 입력하세요..."
search_placeholder_text : "검색어를 입력하세요."
search_algolia_no_results :
results_found : "개 결과 발견"
back_to_top : "맨 위로 이동"
Expand Down
2 changes: 2 additions & 0 deletions _includes/author-profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ <h3 class="author__name p-name" itemprop="name">
{% endif %}
</div>

{% if author %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary. We're already using {% if author.avatar %} above, so either the build errors out, or this check always passes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of author.avatar's conditional statement.
The intention is to prevent the following phenomenon.

[Intended situation]

  • I want to mark the avatar.
  • I don't want to show links.

[Actual results]

  • Avatar is displayed. (It's OK)
  • Links are not displayed. (It's OK)
  • However, when the screen is reduced, the 'Follow' button is displayed for no use.' (Why?)
  • Even if I click the 'Follow' button, there are no links to display, so I only see empty spaces. (Why?)

[Conclusion]
In the end, the phrase {%ifauthor%} was used to turn on/off the "url wrapper" that determines the "follow" button display.
If there is a better way, it doesn't matter if you write another conditional statement.

What I wanted to do was disable url wrapper because if there is no information to follow, such as links and sns accounts, there is no reason for the 'follow' button to be displayed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced this will work as intended. For {% if author %} to fail, you must omit the entire author key (so it evaluates to nil). In this case, there's no way to display an avatar.

<div class="author__urls-wrapper">
<button class="btn btn--inverse">{{ site.data.ui-text[site.locale].follow_label | remove: ":" | default: "Follow" }}</button>
<ul class="author__urls social-icons">
Expand Down Expand Up @@ -243,4 +244,5 @@ <h3 class="author__name p-name" itemprop="name">
{% include author-profile-custom-links.html %}
</ul>
</div>
{% endif %}
</div>
Loading