Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureBlobArtifactRepository to support custom CA certs #7999

Merged
merged 2 commits into from
Mar 14, 2023
Merged

AzureBlobArtifactRepository to support custom CA certs #7999

merged 2 commits into from
Mar 14, 2023

Conversation

martlaf
Copy link
Contributor

@martlaf martlaf commented Mar 8, 2023

Related Issues/PRs

Fixes #7911

What changes are proposed in this pull request?

Adding support for MLFLOW_TRACKING_SERVER_CERT_PATH and MLFLOW_TRACKING_INSECURE_TLS environment variables when configuring AzureBlobArtifactRepository connection.

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Also tested locally with self-signed certs using Azurite storage.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Mar 8, 2023

Documentation preview for f9e5105 will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/artifacts Artifact stores and artifact logging integrations/azure Azure and Azure ML integrations labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

@martlaf Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@martlaf martlaf changed the title Feat/azure blob ca certs AzureBlobArtifactRepository to support custom CA certs Mar 8, 2023
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @martlaf !

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Mar 14, 2023
@martlaf
Copy link
Contributor Author

martlaf commented Mar 14, 2023

Sorry, first time here. I have set the release notes category to none; I don't believe I have access to rerun failing validation. Let me know if I missed something.

@dbczumar
Copy link
Collaborator

Excellent! Thanks so much, @martlaf! Merging :D

@dbczumar dbczumar merged commit dcdc0db into mlflow:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Artifact stores and artifact logging integrations/azure Azure and Azure ML integrations rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] AzureBlobArtifactRepository to support MLFLOW_TRACKING_SERVER_CERT_PATH env var
3 participants