Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLflow UI changes #7923

Merged
merged 4 commits into from
Mar 2, 2023
Merged

MLflow UI changes #7923

merged 4 commits into from
Mar 2, 2023

Conversation

dbczumar
Copy link
Collaborator

@dbczumar dbczumar commented Mar 1, 2023

What changes are proposed in this pull request?

MLflow UI changes

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Verified that experiment page table view, chart view, load more, description editing work. Verified that runs page loads, artifacts render (including PNG), tags can be set. Verified experiment sidebar + experiment creation works. Verified that model registration works. Verified models page and model versions page work, including descriptions, tags, and model version comparison. Verified run comparison page (deprecated) loads and works.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

@dbczumar Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. labels Mar 1, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Mar 1, 2023

Documentation preview for 2a9be02 will be available here when this CircleCI job completes successfully.

More info

@dbczumar dbczumar requested a review from harupy March 1, 2023 23:14
Zangr and others added 3 commits March 1, 2023 15:25
GitOrigin-RevId: 43bbfb7db41f183e772350288bd9838da4fd5360
Signed-off-by: dbczumar <[email protected]>
Signed-off-by: dbczumar <[email protected]>
@harupy
Copy link
Member

harupy commented Mar 2, 2023

LGTM once

# TODO: Reenable ES lint warnings before the MLflow 2.3.0 release
has been removed!

Signed-off-by: dbczumar <[email protected]>
@dbczumar
Copy link
Collaborator Author

dbczumar commented Mar 2, 2023

LGTM once

# TODO: Reenable ES lint warnings before the MLflow 2.3.0 release

has been removed!

Done :)

@dbczumar dbczumar merged commit c187443 into mlflow:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants