-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support uv in mlflow.models.predict #13824
Conversation
Documentation preview for 4e53187 will be available when this CircleCI job More info
|
Imagine you manage everything in uv and have a |
Can we update https://mlflow.org/docs/latest/model/dependencies.html#how-to-fix-dependency-errors-when-serving-my-model section to fully explain and provide a comparison for package managers (uv >> pip >> conda for speed) and to show overriding the env manager option when calling the API? We want to gently push people to using this. Let's also make sure to update https://github.com/mlflow/mlflow/blob/master/mlflow/models/python_api.py#L111-L178 the code block here to show overriding the env_manager parameter to 'uv'. The API docstring could benefit from an explanation of why we're offering this as an option (otherwise users will just gloss over this and not see the benefit). We should probably mention this API where it is most useful too in the docs - in a section right above here: https://mlflow.org/docs/latest/model/signatures.html#id1 as this main page for signatures is frequently visited and this API should be featured here with a brief explanation (and links to the more verbose update section above in dependency error fixing). |
Make sense, I'll file a follow-up doc PR for this |
@harupy Do we have other concerns about this PR? |
_exec_cmd(cmd, capture_output=capture_output, cwd=tmpdir, extra_env=extra_env) | ||
|
||
return activate_cmd | ||
if pip_requirements_override: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a validation test with a lightweight package where we're overriding a package requirement for a model and verify that the updated version is installed without issue (custom pyfunc that just calls __version__
on the update package as a return value is probably sufficient).
It would be nice to ensure that we're testing both virtualenv and uv functionality for this to make sure that both handle this properly (this should just work for virtualenv, but my only concern is that uv might have some secret caching in place that might behave differently than we expect).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mlflow/tests/models/test_python_api.py
Lines 88 to 92 in a28bf5e
@pytest.mark.parametrize( | |
"env_manager", | |
[VIRTUALENV, CONDA, UV], | |
) | |
def test_predict_with_pip_requirements_override(env_manager): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once https://github.com/mlflow/mlflow/pull/13824/files#r1871739656 is addressed! Thanks for this feature - it's going to be great :D
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments, otherwise LGTM!
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]> Signed-off-by: k99kurella <[email protected]>
Signed-off-by: serena-ruan <[email protected]> Signed-off-by: k99kurella <[email protected]>
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Support uv as a env manager for running mlflow.models.predict
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yes
should be selected for bug fixes, documentation updates, and other small changes.No
should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.