-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent clean_up_envs
from deleting local development environment
#11249
Conversation
Signed-off-by: harupy <[email protected]>
Documentation preview for 464fc00 will be available when this CircleCI job More info
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Good improvement for testing!
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
@@ -272,8 +276,11 @@ def clean_up_envs(): | |||
if os.name != "nt": | |||
conda_info = json.loads(subprocess.check_output(["conda", "info", "--json"], text=True)) | |||
root_prefix = conda_info["root_prefix"] | |||
regex = re.compile(r"mlflow-\w{32,}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ai I want some examples strings that matches this regular expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex matches any string that starts with "mlflow-" followed by at least 32 alphanumeric characters (i.e., letters a-z, A-Z, or numbers 0-9). Here are a few example strings that would match:
mlflow-12345678901234567890123456789012
mlflow-abcdefghijklmnopqrstuvwxzyz123456
mlflowabcdefghijklmnopqrstuvwxyzabcdefg
mlflow-09876543210987654321098765432100
Please note that any extra characters after the initial 32 alphanumeric characters will still match.
Click here to see the usage data
{
"prompt_tokens": 62,
"completion_tokens": 129,
"total_tokens": 191,
"estimated_cost_in_usd": 0.0096
}
…lflow#11249) Signed-off-by: harupy <[email protected]>
…lflow#11249) Signed-off-by: harupy <[email protected]> Signed-off-by: Arthur Jenoudet <[email protected]>
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
clean_up_envs
accidentally removed my local dev environment. This PR makes a change to prevent that.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes