Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clean_up_envs from deleting local development environment #11249

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

harupy
Copy link
Member

@harupy harupy commented Feb 26, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/11249/merge

Checkout with GitHub CLI

gh pr checkout 11249

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

clean_up_envs accidentally removed my local dev environment. This PR makes a change to prevent that.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Copy link

github-actions bot commented Feb 26, 2024

Documentation preview for 464fc00 will be available when this CircleCI job
completes successfully.

More info

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Feb 26, 2024
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good improvement for testing!

Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
@@ -272,8 +276,11 @@ def clean_up_envs():
if os.name != "nt":
conda_info = json.loads(subprocess.check_output(["conda", "info", "--json"], text=True))
root_prefix = conda_info["root_prefix"]
regex = re.compile(r"mlflow-\w{32,}")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ai I want some examples strings that matches this regular expression

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy

This regex matches any string that starts with "mlflow-" followed by at least 32 alphanumeric characters (i.e., letters a-z, A-Z, or numbers 0-9). Here are a few example strings that would match:

  1. mlflow-12345678901234567890123456789012
  2. mlflow-abcdefghijklmnopqrstuvwxzyz123456
  3. mlflowabcdefghijklmnopqrstuvwxyzabcdefg
  4. mlflow-09876543210987654321098765432100

Please note that any extra characters after the initial 32 alphanumeric characters will still match.

Click here to see the usage data
{
  "prompt_tokens": 62,
  "completion_tokens": 129,
  "total_tokens": 191,
  "estimated_cost_in_usd": 0.0096
}

@harupy harupy merged commit dd03bc5 into mlflow:master Feb 26, 2024
37 checks passed
@harupy harupy deleted the guardrail-clean_up_envs branch February 26, 2024 12:38
serena-ruan pushed a commit to serena-ruan/mlflow that referenced this pull request Feb 28, 2024
artjen pushed a commit to artjen/mlflow that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants