-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy Multipart Upload for Azure Blob Storage #10531
Conversation
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Documentation preview for 223f7b1 will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
# Conflicts: # mlflow/store/artifact/http_artifact_repo.py Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
blob_client.commit_block_list(block_ids) | ||
|
||
def abort_multipart_upload(self, local_file, upload_id, artifact_path=None): | ||
# There is no way to delete uncommitted blocks in Azure Blob Storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great comment
blob_name=dest_path, | ||
account_key=self.client.credential.account_key, | ||
permission=BlobSasPermissions(read=True, write=True), | ||
expiry=datetime.datetime.utcnow() + datetime.timedelta(hours=6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about the expiration time - is this something that Azure recommends for duration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misread the documentation somewhere. Let me change to 1 hour to align with our s3 & gcs impl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for knocking this out @gabrielfu :D
Signed-off-by: Gabriel Fu <[email protected]> Signed-off-by: Gabriel Fu <[email protected]>
@gabrielfu Let's wait until after the 2.9 release to merge this :D |
Signed-off-by: Gabriel Fu <[email protected]>
Sure! |
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Implement proxy multipart upload for Azure Blob Storage
Example:
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Implement proxy multipart upload for Azure Blob Storage
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes