-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recall @ k for retriever eval #10144
Conversation
Signed-off-by: Bryan Qiu <[email protected]>
Documentation preview for b7efcab will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Liang Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left a couple small comments. @bbqiu do we already have an example checked in for retriever eval? doesn't need to be super fancy -- something in examples/evaluation/
that can run manually would be great.
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
824a212
to
771f963
Compare
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
683d742
to
ad04937
Compare
commit 827d31e Author: Harutaka Kawamura <[email protected]> Date: Fri Oct 27 12:17:31 2023 +0900 Fix lint error on master (mlflow#10181) Signed-off-by: harupy <[email protected]> commit 15e5b94 Author: Daniel Lok <[email protected]> Date: Fri Oct 27 10:57:25 2023 +0800 Add param to enable/disable saving ONNX model as external data (mlflow#10152) Signed-off-by: Daniel Lok <[email protected]> commit a8ef779 Author: Harutaka Kawamura <[email protected]> Date: Fri Oct 27 11:34:29 2023 +0900 Fix lint job condition (mlflow#10179) Signed-off-by: harupy <[email protected]> commit 8c63df6 Author: Prithvi Kannan <[email protected]> Date: Thu Oct 26 18:33:02 2023 -0700 Remove other timeouts (mlflow#10172) commit f10fbd3 Author: Prithvi Kannan <[email protected]> Date: Thu Oct 26 18:30:58 2023 -0700 Surface openai error (mlflow#10176) commit d9b8d17 Author: Ann Zhang <[email protected]> Date: Thu Oct 26 18:00:35 2023 -0700 Fix typo (mlflow#10175) Signed-off-by: Ann Zhang <[email protected]> Signed-off-by: Bryan Qiu <[email protected]>
581a82f
to
6d06cbf
Compare
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Retriever change pandas hash
Signed-off-by: Bryan Qiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work, @bbqiu !
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]>
Signed-off-by: Bryan Qiu <[email protected]> Signed-off-by: Liang Zhang <[email protected]> Co-authored-by: Liang Zhang <[email protected]> Signed-off-by: swathi <[email protected]>
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes