Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount options from the CLI #279

Merged
merged 16 commits into from
Aug 15, 2023

Conversation

davidjurado
Copy link
Contributor

@davidjurado davidjurado commented Nov 3, 2022

This PR contains the feature to define the mount options from the CLI, this will override all mount options for the input parameters specified in the mlcube.yaml.

Example:

 mlcube run --task=hello --mount=ro

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@davidjurado davidjurado changed the title Add mount options from the CLI [WIP] Add mount options from the CLI Nov 4, 2022
@davidjurado davidjurado force-pushed the feature/cli_mount branch 4 times, most recently from 3f46393 to 1fd29f0 Compare November 11, 2022 16:11
@davidjurado davidjurado changed the title [WIP] Add mount options from the CLI Add mount options from the CLI Nov 18, 2022
@davidjurado davidjurado requested a review from a team as a code owner June 23, 2023 14:39
@davidjurado davidjurado force-pushed the feature/cli_mount branch 4 times, most recently from 8414d60 to fb198bf Compare June 23, 2023 15:26
Copy link
Contributor

@sergey-serebryakov sergey-serebryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sergey-serebryakov sergey-serebryakov merged commit 394a301 into mlcommons:master Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants