-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mount options from the CLI #279
Merged
sergey-serebryakov
merged 16 commits into
mlcommons:master
from
davidjurado:feature/cli_mount
Aug 15, 2023
Merged
Add mount options from the CLI #279
sergey-serebryakov
merged 16 commits into
mlcommons:master
from
davidjurado:feature/cli_mount
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
3f46393
to
1fd29f0
Compare
1fd29f0
to
4a1208e
Compare
8414d60
to
fb198bf
Compare
fb198bf
to
8a43955
Compare
…o david/cli_mount - Resolving conflicts. - Updating unit tests.
Resolving merge conflicts and updating unit tests.
Removing redundant import.
sergey-serebryakov
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the feature to define the mount options from the CLI, this will override all mount options for the input parameters specified in the mlcube.yaml.
Example: