-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support find cache + gh action for core mlc actions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Jan 25, 2025
arjunsuresh
reviewed
Jan 25, 2025
Hi @anandhu-eng is this ready to be merged or do we need more tests for the actions? |
5 tasks
Hi @arjunsuresh , I think this could be merged, but we need to add GH actions of rest of the core functionalities in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes proposed are to support
mlc find cache
command in MLC and to initiate the GitHub action for testing the core MLC actions.After merging the PR, it may be observed that there are duplicate print statements of WARNING - No cache entry found for the specified tags! are being found when executing a script. Example is given below:
This is due to the automation script in
mlperf-automations
repo calling thefind
action of MLC.@arjunsuresh , would it be a good solution that we replace the calling of
find
action inmlperf-automation
tosearch
?