-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics library updated to support comma separate inputs #900
Metrics library updated to support comma separate inputs #900
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Marking this as draft until this gets checked by @vpchung. |
Hi @sarthakpati @VukW - the entrypoint tests are failing with this error:
I am sure why this is the case. Could one of you please help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a couple of suggestions, but they're minor.
target_df = target_df.rename(columns={target_df.columns[1]: "Target"}) | ||
prediction_df = prediction_df.rename( | ||
columns={prediction_df.columns[1]: "Prediction"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that the second column is always the one that contains the target or prediction values. Perhaps an assertion can be added before this to ensure that the first column is "SubjectID" before renaming the second column (on the off-chance that "SubjectID" is second column instead of the first).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be addressed - can you please check?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-apis_v0.1.0-dev #900 +/- ##
=======================================================
+ Coverage 94.40% 94.45% +0.04%
=======================================================
Files 158 159 +1
Lines 9314 9391 +77
=======================================================
+ Hits 8793 8870 +77
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes in wording
Co-authored-by: Sarthak Pati <[email protected]>
Co-authored-by: Sarthak Pati <[email protected]>
Fixes #N.A.
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].