Simple pattern support + integer ranges #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joennlae Thanks for your contribution! Sorry for not replying to you in time, and I will review the code later today |
Ubospica
requested changes
Dec 5, 2024
| @@ -652,6 +654,122 @@ std::string JSONSchemaConverter::VisitAny( | |||
| kBasicArray + " | " + kBasicObject; | |||
| } | |||
|
|
|||
| std::string generateRangeRegex(std::optional<int> start, std::optional<int> end) { | |||
There was a problem hiding this comment.
Could you make generateRangeRegex a static member function of JSONSchemaConverter, and follow the naming conversion (GenerateRangeRegex)?
| std::string converted_regex = RegexToEBNF(range_regex, false); | ||
| return converted_regex; // not " " for numbers | ||
| } | ||
| } catch (const std::exception& e) { |
There was a problem hiding this comment.
Please remove the usage of try-catch block and std::exception. The reason is we maintain a typescript binding running in WASM, which has not supported exceptions yet. Just throw an error at the error line.
Ubospica
approved these changes
Dec 6, 2024
|
We can merge this PR now, and I will update according to the above comments in a new PR. Thanks @joennlae! |
Ubospica
added a commit
that referenced
this pull request
Dec 6, 2024
This PR updates the changes in #106. It removes the try-catch block, and make GenerateRangeRegex a static member function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces simple regex pattern support + integer ranges.