Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mistral and Phi to model table #1553

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

philippgille
Copy link
Contributor

I was looking into running a good embedding model locally. The popular embedding model leaderboard currently (2024-01-07) shows e5-mistral-7b-instruct as top entry. I checked mlc-llm's README and it didn't seem to support the Mistral architecture. Only when checking the docs that turned out to be wrong.

=> As many people might be quick to leave when not finding Mistral on the README, I propose to include this info on the README directly, instead of only in the docs.

To have a smaller README, maybe some of the other listed models can be removed, which might be less popular?

It might also be worth adding one row with ... or ... (see docs) with a link, to the docs, which might make clearer that people should check the link and it's easier/quicker to see than reading the text paragraph above the table.
If you want, I can adjust this PR accordingly.

@junrushao
Copy link
Member

CC: @CharlieFRuan

Copy link
Contributor

@CharlieFRuan CharlieFRuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the suggestions; we'll think about making the README more direct!

@CharlieFRuan CharlieFRuan merged commit e9afc9c into mlc-ai:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants