Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLM] Batched Llama #1520

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[SLM] Batched Llama #1520

merged 1 commit into from
Jan 4, 2024

Conversation

MasterJH5574
Copy link
Member

This PR introduces the batched llama modeling with Paged KV cache in SLM flow.

@MasterJH5574 MasterJH5574 marked this pull request as draft December 31, 2023 04:52
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch 2 times, most recently from 1e811f6 to 2295999 Compare December 31, 2023 15:23
junrushao
junrushao reviewed Jan 1, 2024
View reviewed changes
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch 8 times, most recently from 090d6eb to 6eb18f4 Compare January 2, 2024 15:04
@MasterJH5574 MasterJH5574 marked this pull request as ready for review January 2, 2024 15:18
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch 6 times, most recently from 747cd93 to 6d6357f Compare January 2, 2024 21:01
junrushao
junrushao reviewed Jan 3, 2024
View reviewed changes
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch 2 times, most recently from e1cc139 to 08874b8 Compare January 4, 2024 04:08
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch 4 times, most recently from 319ce79 to 4f2a69f Compare January 4, 2024 18:35
junrushao
junrushao approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MasterJH5574
[SLM] Batched Llama
27cd520 
This PR introduces the batched llama modeling with Paged KV cache
in SLM flow.
@MasterJH5574 MasterJH5574 force-pushed the 12-30-slm-batched-llama branch from 9292f62 to 27cd520 Compare January 4, 2024 18:42
@tqchen tqchen merged commit 7239a91 into mlc-ai:main Jan 4, 2024
MasterJH5574 added a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow
f28568e 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow
c776063 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow
b2c7ab9 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow
b14b5b9 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
@MasterJH5574 MasterJH5574 mentioned this pull request Jan 4, 2024
Merged
MasterJH5574 added a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow
abdacdf 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
junrushao pushed a commit that referenced this pull request Jan 4, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow (#1537)
a947fbd 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit to MasterJH5574/mlc-llm that referenced this pull request Jan 10, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow (mlc-ai#1537)
a87fc95 
PR mlc-ai#1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit that referenced this pull request Jan 10, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow (#1537)
2854061 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
MasterJH5574 added a commit to MasterJH5574/mlc-llm that referenced this pull request Jan 12, 2024
@MasterJH5574
[Serving] Switching to SLM model definition flow (mlc-ai#1537)
a29cb5d 
PR mlc-ai#1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
tqchen pushed a commit that referenced this pull request Jan 12, 2024
@MasterJH5574 @tqchen
[Serving] Switching to SLM model definition flow (#1537)
d34c729 
PR #1520 introduces batched llama to SLM. This PR
updates the serving codebase and fully switch the model
definition to SLM flow. Most changes in this PR are trivial.

Note that with this PR merged in, the previous batching
model definition flow becomes outdated and no longer
usable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasterJH5574 @tqchen @junrushao