Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated binary libs #89

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Remove deprecated binary libs #89

merged 1 commit into from
Feb 15, 2024

Conversation

rickzx
Copy link
Contributor

@rickzx rickzx commented Feb 15, 2024 •
edited by CharlieFRuan
Loading

@rickzx
Copy link
Contributor Author

rickzx commented Feb 15, 2024 •
edited
Loading

Hi @Kartik14 I moved the binary libs you compiled here: #85 into the individual folders. Do you know if this will break anything in Android?

@Kartik14
Copy link
Contributor

The users will just have to update the paths to the binary libs in their prepare_libs.sh. The script throws an error if it is unable to find the libs so should be easy to debug hopefully.

@rickzx rickzx merged commit 5a69e51 into mlc-ai:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieFRuan CharlieFRuan CharlieFRuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickzx @Kartik14 @CharlieFRuan