Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass on sever process environment to child processes (option -e) #118

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

rvollgraf
Copy link
Contributor

The environment of the ssh server process is usually cleared and not passed on to the child process for security reasons. However, in certain situations it may be desirable to inherit the server environment. For example: I start dropbear (as non-root) from a SLURM workload manager, which exposes a lot variables containing of information about the confined runtime environment. These need to be inherited by child processes which are also subject to SLURM's runtime environment.

@elgalu
Copy link

elgalu commented Aug 19, 2021

Hi @mkj , is this not merged because of coding style? or do you see some security risk in this feature?

@mkj
Copy link
Owner

mkj commented Aug 19, 2021

Sorry, I've just been lax in looking at pull requests, I think the patch looks good. @rvollgraf in the manpage you mention security issues - I can think of possible information disclosure from the parent process, is there something else you were thinking of?

@rvollgraf
Copy link
Contributor Author

rvollgraf commented Aug 19, 2021

Honestly, I don't really know. I guess it is for some reason that the env is cleaned by default. So I thought some "use it at your own risk" disclaimer might be appropriate.

@mkj mkj merged commit 2157d52 into mkj:master Aug 19, 2021
@mkj
Copy link
Owner

mkj commented Aug 19, 2021

Thanks, I've changed the description slightly.

69e5709

Pass on the server environment to all child processes. This is required, for example,
if Dropbear is launched on the fly from a SLURM workload manager. The environment is not
passed by default. Note that this could expose secrets in environment variables from
the calling process - use with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants