Issue: #44: (New feature) Add option to set default peeks aka context lines #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 6, 2018
conflict/conflict_test.go
Outdated
|
|
||
| for _, tt := range testCases { | ||
| if err := c.SetPeeks(tt.in); err != nil { | ||
| testhelper.Assert(t, tt.err == true, "Didn't expect error to be returned, input: %s", tt.in) |
There was a problem hiding this comment.
should omit comparison to bool constant, can be simplified to tt.err
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
+ Coverage 85.13% 85.5% +0.36%
=========================================
Files 8 8
Lines 397 407 +10
=========================================
+ Hits 338 348 +10
Misses 30 30
Partials 29 29
Continue to review full report at Codecov.
|
mkchoi212
reviewed
Sep 6, 2018
|
Looks great! Thanks for the contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default_context_lines to 2. Let me know if this is not intended.