fix: adjustments for FV3_HRRR_gf in SRW for global physics suite

[benkozi]

No description provided.

[benkozi]

@mkavulich - We can reduce the number of changes here if you merge https://github.com/ufs-community/ufs-srweather-app/tree/develop into this bug fix branch. I'll be looking into automatically setting LEVP based on the requested physics suite.

[mkavulich]

@benkozi done, let me know if you need anything else

[benkozi]

@mkavulich - This is ready for a review/merge when you have time.

[mkavulich]

The CCPP suite shouldn't depend on the number of vertical levels, any suite can be used with any number of vertical levels assuming the correct vertical coordinate file is used (see users guide: https://ufs-srweather-app.readthedocs.io/en/latest/UsersGuide/CustomizingTheWorkflow/LAMGrids.html#verticallevels). I'm not sure the exact reasons why a different number of vertical levels is needed, but I'm guessing it's something specific to the smoke/dust configuration. So maybe these changes are what you want?

Suggested change

	# Verify correct LEVP specified for FV3_HRRR_gf
	if expt_config["workflow"].get("CCPP_PHYS_SUITE") == "FV3_HRRR_gf":
	task_names = ("task_make_ics", "task_make_lbcs")
	not_correct_levp = [task_name for task_name in task_names if expt_config[task_name].get("LEVP") != 66]
	vcoord_file = "{{ workflow.FIXam }}/global_hyblev_fcst_rrfsL65.txt"
	if len(not_correct_levp) > 0:
	raise ValueError(f"Set 'LEVP: 66' and 'VCOORD_FILE: \"{vcoord_file}\"' in task(s) '{not_correct_levp}' when using 'CCPP_PHYS_SUITE: FV3_HRRR_gf'")
	# Verify correct LEVP specified for FV3_HRRR_gf
	if expt_config['smoke_dust_parm'].get('DO_SMOKE_DUST'):
	task_names = ("task_make_ics", "task_make_lbcs")
	not_correct_levp = [task_name for task_name in task_names if expt_config[task_name].get("LEVP") != 66]
	vcoord_file = "{{ workflow.FIXam }}/global_hyblev_fcst_rrfsL65.txt"
	if len(not_correct_levp) > 0:
	raise ValueError(f"Set 'LEVP: 66' and 'VCOORD_FILE: \"{vcoord_file}\"' in task(s) '{not_correct_levp}' when using 'DO_SMOKE_DUST: True'")

This hard-coding is still imperfect though because I don't think a specific configuration should require a specific number of vertical levels.

[benkozi]

I'll reach out to SD folks about this. What's interesting is that this is required when rrfs_sd = .false.. So it could be some other parameter in the namelist is triggering (which you've mentioned).