Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating #342

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Templating #342

merged 6 commits into from
Feb 18, 2022

Conversation

kmcb777
Copy link
Contributor

@kmcb777 kmcb777 commented Feb 22, 2021

@azrael As iryusa said, we wanted to add handlebars support as well
I started from your branch, and added support for handlebars
I added the possibility to enter the variables as Json (you can choose between yaml and Json)
I also made the variables to be saved separately for each project
Finally i moved the "templating settings" button in the top bar, on the line with the "beautify", "send" and other buttons, to make it more visible
If you have any suggestions, feel free to comment
And thanks again, this is a very nice new feature !

@iRyusa
Copy link
Member

iRyusa commented Jun 11, 2021

Can we mark this as a "beta" in the app maybe @kmcb777 ? and add a link to an issue here with feedback from people using it

@azrael
Copy link
Contributor

azrael commented Jan 30, 2022

Oh my! Sorry, I completely missed this PR. It's been a busy... year )
Yeah, your additions look reasonable. Also, I only used yaml for the "less characters" reason. So feel free to replace it with JSON if you like.
BTW you can close my PR as it is included in this one )

@kmcb777 kmcb777 merged commit 4a5d283 into master Feb 18, 2022
@kmcb777 kmcb777 deleted the templating branch February 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants