Skip to content

Commit

Permalink
refactor(UserController) : 비즈니스 로직을 서비스 객체가 갖도록 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
mjj111 committed May 20, 2024
1 parent fc448bc commit ec127f4
Showing 1 changed file with 15 additions and 11 deletions.
26 changes: 15 additions & 11 deletions src/main/java/client/controller/UserController.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package client.controller;

import client.controller.dto.CreatUserDto;
import client.model.User;
import client.service.UserService;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import spring.mvc.annotation.Controller;
Expand All @@ -9,36 +11,38 @@
import spring.mvc.handler.mapping.RequestMethod;
import spring.mvc.view.ModelAndView;

import java.util.List;

@Controller
public class UserController extends AbstractController {

private final UserService userService;

public UserController(final UserService userService) {
this.userService = userService;
}

@RequestMapping("/users")
public ModelAndView getUsers(HttpServletRequest request, HttpServletResponse response) {
int wannaSize = Integer.parseInt(request.getParameter("size"));
List<User> users = userService.getUsersWithSize(wannaSize);

ModelAndView modelAndView = jsonView();
for(int i = 0; i < wannaSize; i++) {
User newUser = new User(String.valueOf(i),
"tmpPassword",
i + "김명준",
"[email protected]");

modelAndView.addObject("user"+ i, newUser);
User user = users.get(i);
modelAndView.addObject("user"+ i, user);
}

return modelAndView;
}

@RequestMapping(value = "/users/create", method = RequestMethod.POST)
public ModelAndView create(HttpServletRequest request, HttpServletResponse response) {
User user = new User(request.getParameter("userId"),
request.getParameter("password"),
request.getParameter("name"),
request.getParameter("email"));
CreatUserDto requestDto = CreatUserDto.of(request);
User user = userService.createUser(requestDto);

ModelAndView modelAndView = jsonView();
modelAndView.addObject("user", user);

return modelAndView;
}
}

0 comments on commit ec127f4

Please sign in to comment.