Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent querying of db when compiling #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablo-statsig
Copy link

This is a:

  • [ x ] bug fix PR with no breaking changes
  • new functionality
  • a breaking change

Description & motivation

I keep seeing these weird fake test failures when running dbt compile. Based on this conversion dbt-labs/dbt-core#4575 (comment) it seems to be because dbt compile sets execute to true during one of its phases. This makes it so that db parsing is also stopped when compiling

Checklist

  • [ x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • [ x] BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my macros (and models if applicable)

I keep seeing these weird fake test failures when running dbt compile. Based on this conversion dbt-labs/dbt-core#4575 (comment) it seems to be because dbt compile sets execute to true during one of its phases. This makes it so that db parsing is also stopped when compiling
@pablo-statsig pablo-statsig requested a review from mjirv as a code owner July 11, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant