Merge pull request #2 from daattali/master

Update from daatali/shinyjs.. non-selectize select inputs could not be disabled; fixes daattali#186
mjhelf · Jul 18, 2019 · 8d51659 · 8d51659
2 parents 138a813 + a77d96a
commit 8d51659
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: shinyjs
 Title: Easily Improve the User Experience of Your Shiny Apps in Seconds
-Version: 1.0.1.9004
+Version: 1.0.1.9005
 Authors@R: person("Dean", "Attali", email = "[email protected]",
     role = c("aut", "cre"))
 Description: Perform common useful JavaScript operations in Shiny apps that will

diff --git a/NEWS.md b/NEWS.md
@@ -7,6 +7,7 @@
 - Add `asis` parameter to any function that takes an ID. When `asis=TRUE`, the ID will not be namespaced when inside a module (#118)
 - **BREAKING CHANGE** The `includeShinyjs` parameter in `runcodeUI()` is now deprecated
 - Fix bug: shinyjs functions did not work with IDs that had a space in them; fixes #176
+- Fix bug #186: non-selectize select inputs could not be disabled
 
 # shinyjs 1.0
 

diff --git a/inst/srcjs/shinyjs-default-funcs.js b/inst/srcjs/shinyjs-default-funcs.js
@@ -235,7 +235,7 @@ shinyjs = function() {
 
       // enable/disable the container as well as all individual inputs inside
       // (this is needed for grouped inputs such as radio and checkbox groups)
-      var toadd = $el.find("input, button, textarea");
+      var toadd = $el.find("input, button, textarea, select");
       $el = $($el.toArray().concat(toadd.toArray()));
       $el.attr('disabled', (method == "disable"));
       $el.prop('disabled', (method == "disable"));