Buffer local swaplist #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With only one global g:swap_lists, setting the swaplist for one filetype overrides the previous filetype's list. This breaks swapping with multiple filetypes in parallel (e.g. a PHP and CSS file); the last opened filetype "wins". Instead, a buffer-local variable should be used. Each buffer has its own swaplist (according to its filetype / manual :SwapList) definition then.
As this configuration is filetype-specific, too.
Also, I've removed the duplicate multi-word swap list comment from the plugin, as this is already explained at :help swapit-multiword. Probably, a lot more unnecessary stuff should be cut from the plugin's comment header.
|
Cheers, Thanks for this update. I was never happy with the original setup and the :ClearSwapList command was always a bit of a hack. Speaking of FileType lists do you have any worth publishing? I was hoping for contributions (perhaps as separate archives). |
|
Thank you for accepting all my recent pull requests so quickly. I have customized your lists for CSS and HTML a bit, and added one swap list for ActionScript, but I mostly use an extended set of default swaps. Having more default swaps would be nice, on the other hand, it's also easy to set them up yourself. |
|
No probs. I'll try and publish the updates soon on vim.org. I have an optional syntax_hightlight feature I just cooked up that I'll post as well once it's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With only one global
g:swap_lists, setting the swaplist for one filetype overrides the previous filetype's list. This breaks swapping with multiple filetypes in parallel (e.g. a PHP and CSS file); the last opened filetype "wins".Instead, a buffer-local variable should be used. Each buffer has its own swaplist (according to its filetype / manual
:SwapList) definition then.