Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onFlushComplete callback #168

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Add onFlushComplete callback #168

merged 1 commit into from
Feb 27, 2024

Conversation

elic-sightful
Copy link
Contributor

Consider the following scenario:

  • The user shuts down the application
  • We generate events that are related to this, and want to flush them before shutdown completes
  • In order to do this, we need to know that the Flush command has finished so that shutdown can proceed

This PR adds an optional callback that will be invoked once Flush has finished. In addition, it can signal the caller if the flush was successful or not.

@zihejia

zihejia
zihejia approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elic-sightful thank you so much!

@zihejia zihejia merged commit 7c83a60 into mixpanel:master Feb 27, 2024
@elic-sightful elic-sightful deleted the flush-done-callback branch February 28, 2024 09:23
@elic-sightful
Copy link
Contributor Author

@zihejia Thanks for merging!
When will this be available in an official release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elic-sightful @zihejia