Remove NPS survey and add more DevX tracking #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
force-pushed
the
dexX-tracking-improvement
branch
from
58e3281 to
31b28ae
Compare
| @@ -345,6 +378,9 @@ internal static void DoEngage(Value properties) | |||
| properties["$mp_metadata"] = Metadata.GetPeopleMetadata(); | |||
|
|
|||
| MixpanelStorage.EnqueueTrackingData(properties, MixpanelStorage.FlushType.PEOPLE); | |||
| if (Debug.isDebugBuild) { | |||
| MixpanelStorage.HasUsedPeople = true; | |||
There was a problem hiding this comment.
no automatic people updates to check for on Unity?
There was a problem hiding this comment.
there are no automatic people updates in unity
Mixpanel/MixpanelAPI.cs
Outdated
| @@ -257,6 +259,7 @@ public static void Track(string eventName, string key, Value value) | |||
| Value properties = new Value(); | |||
| properties[key] = value; | |||
| Controller.DoTrack(eventName, properties); | |||
| MixpanelStorage.HasTracked = true; | |||
There was a problem hiding this comment.
looks like this is set to true inside of DoTrack() on the line above, right?
jaredmixpanel
approved these changes
May 21, 2022
zihejia
force-pushed
the
dexX-tracking-improvement
branch
from
31b28ae to
6a3611d
Compare
zihejia
force-pushed
the
dexX-tracking-improvement
branch
from
6a3611d to
f58a5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.