-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions fix: r-cmd-check #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated R to 4.4.1 - updated renv version - updated all dependencies in renv.lock to latest versions and updated renv.lock - commit updated configuration files in renv/ folder
- added Saritha's algorithm alongside a BiocParallel implementation which shows reasonable use-cases for certain input sizes - delete old dtt based implementation - updat dep's with gsignal and remove dtt - move old validated function to testing module for later comparison - TODO: write some sensible tests in the testing file....
LABWORK - 7/08/2024
need to worry about writing better tensor docs in the future...
finnicky - allow specification of multiple observations of categorical label across time points, with potentially new classes introduced that were not present in previous time points
Devtools::check() working on Windows! (+ add / fix some tensor stuff)
…mixOmics into github-actions-fix
…mics functions during vignette building
…void windows errors on parallel workers
need to really really fix these later
Write some rough placeholder docstrings
…s to match previous checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactorisation
For improvements to the package which don't change functionality, just improve backend structure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Github actions have been failing on scheduled weekly triggers and everytime a branch is pulled or PRs made for the last few months.
Changes to github actions:
Refactored the code in github actions to ensure tests run properly across macOS, windows and linux github runners:
r-hub/sysreqs
doesn’t work anymore:sysreqs
was archived on 15th April 2024 (https://github.com/r-hub/sysreqs), plus the server which sysreqs needs to access isn't avaliable (sysreqs.r-hub.io). This caused an error when sysreqs was triggered in the GitHub actionSSL peer certificate or SSH remote key was not OK
sysreqs
:r-lib/actions/setup-r-dependencies@v2
rmcdcheck
todevtools::check()
because the former was failing on windows runnerdevtools::install()
and thendevtools::check
, so for this reason we have swapped fromrmdcheck
todevtools
to perform the check. Check should still be performed in the same way.rcmdcheck::rcmdcheck(args = c("--no-manual"), error_on = "warning", check_dir = "check")
devtools::check(args = c("--no-manual"), error_on = "warning", check_dir = "check")
rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran", "--ignore-vignettes", "--run-dontrun"), error_on = "never", check_dir = "check/asCRAN", build_args = c("--no-build-vignettes"))
options(devtools.check.dir = "check/asCRAN", devtools.check.warning = "never") devtools::check(args = c("--no-manual", "--as-cran", "--ignore-vignettes", "--run-dontrun"), build_args = c("--no-build-vignettes"))
Additional changes
As well as the github changes, changes to update dependencies to latest R version and new tensor methods were performed by Brendan Lu see:
#313
#314
#315