Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #178 #179

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Fix for Issue #178 #179

merged 2 commits into from
Apr 10, 2022

Conversation

Max-Bladen
Copy link
Collaborator

Added a check within circosPlot.block.spls() (line 451 in circosPlot.R). Determines if object$X$Y is null (which is the case if indY was used in block.spls()). If so, changes the name of the object$X component which corresponds to the Y dataframe to Y. Makes no impact on other plotting functions

@Max-Bladen Max-Bladen self-assigned this Mar 8, 2022
@Max-Bladen Max-Bladen linked an issue Mar 9, 2022 that may be closed by this pull request
@Max-Bladen Max-Bladen added the bug-fix For PR's that address an Issue with `bug` label label Mar 9, 2022
@Max-Bladen
Copy link
Collaborator Author

Added second commit which includes a new test_that call within test-circosPlot.R to maintain coverage percentage

@Max-Bladen Max-Bladen added the rapid-review for PRs which will take minimal time to review and close label Mar 29, 2022
@aljabadi aljabadi merged commit 35d7810 into master Apr 10, 2022
@Max-Bladen Max-Bladen deleted the issue-178 branch April 11, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PR's that address an Issue with `bug` label rapid-review for PRs which will take minimal time to review and close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indY cannot be used in block.spls for circosPlot()
2 participants