Don't over-fire --no-force-pass deprecation warning (#562)

mitsuhiko · Aug 11, 2024 · e4933b5 · e4933b5
1 parent 998d58a
commit e4933b5
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/cargo-insta/src/cli.rs b/cargo-insta/src/cli.rs
@@ -928,14 +928,19 @@ fn prepare_test_runner<'snapshot_ref>(
     if !cmd.fail_fast {
         proc.arg("--no-fail-fast");
     }
-    if !cmd.no_force_pass {
+    if !cmd.check {
         proc.env("INSTA_FORCE_PASS", "1");
-    } else {
+    } else if !cmd.no_force_pass {
+        proc.env("INSTA_FORCE_PASS", "1");
+        // If we're not running under cargo insta, raise a warning that this option
+        // is deprecated. (cargo insta still uses it when running under `--check`,
+        // but this will stop soon too)
         eprintln!(
             "{}: `--no-force-pass` is deprecated. Please use --check to immediately raise an error on any non-matching snapshots.",
             style("warning").bold().yellow()
-        );
+    );
     }
+
     proc.env(
         "INSTA_UPDATE",
         match (cmd.check, cmd.accept_unseen) {