Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy V and SV identifiers from the CCI tags in xccdf2inspec #221

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

Bialogs
Copy link
Contributor

@Bialogs Bialogs commented Mar 15, 2021

Create an additional Ident HappyMapper class and adds an after_parse callback that parses the Ident tag legacy identifier.

Closes #220

@Bialogs Bialogs requested a review from rbclark March 15, 2021 21:10
@Bialogs
Copy link
Contributor Author

Bialogs commented Mar 15, 2021

@aaronlippold Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI).

@aaronlippold
Copy link
Member

aaronlippold commented Mar 15, 2021 via email

lib/inspec_tools/xccdf.rb Outdated Show resolved Hide resolved
@rbclark
Copy link
Collaborator

rbclark commented Mar 16, 2021

Well we want to make them new tags right
On Mon, Mar 15, 2021 at 5:15 PM Kyle @.> wrote: @aaronlippold <@aaronlippold> Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#221 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/AALK42DLQ2IWPM7QEJE3S2TTDZ2HBANCNFSM4ZHINS4A> .
-- -------- Aaron Lippold @.
260-255-4779 twitter/aim/yahoo,etc. 'aaronlippold'

Are you saying you want tag legacy: ['v-xxx', 'sv-xxx] to be added to the output? Or something else?

@aaronlippold
Copy link
Member

aaronlippold commented Mar 16, 2021 via email

@rbclark
Copy link
Collaborator

rbclark commented Mar 16, 2021

Can you provide an example of what you are expecting the output structure of this to look like in inspec? Currently the XCCDF provides no information on what this additional data is other than the fact that it is in the namespace http://cyber.mil/legacy which doesn't provide much in the way of identification.

@Bialogs Bialogs force-pushed the 220-remove_legacy_ids_from_cci_tags branch from b225c20 to 29d4a56 Compare March 16, 2021 14:38
@Bialogs Bialogs force-pushed the 220-remove_legacy_ids_from_cci_tags branch from 29d4a56 to e66be82 Compare March 24, 2021 21:21
@Bialogs Bialogs merged commit dbcc98c into master Mar 24, 2021
@Bialogs Bialogs deleted the 220-remove_legacy_ids_from_cci_tags branch March 24, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V-# and SV-# are being added to the cci array.
3 participants