Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change xtask validate to xtask check when xtask ci is called. #89

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: Change xtask validate to xtask check when xtask ci is called. #89

merged 1 commit into from
May 29, 2024

Conversation

mchernicoff
Copy link
Contributor

Resolves Issue #86 Fixes the xtask ci task to correctly call xtask check instead of the deprecated xtask validate.

@mchernicoff mchernicoff added the type: bug Something isn't working label May 29, 2024
@mchernicoff mchernicoff added this to the 3.3.0 milestone May 29, 2024
@mchernicoff mchernicoff self-assigned this May 29, 2024
j-lanson
j-lanson approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Straightforward change.

@mchernicoff mchernicoff merged commit 9650d9d into main May 29, 2024
9 checks passed
@mchernicoff mchernicoff deleted the mchernicoff/xtask-ci-check branch June 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

@alilleybrinker alilleybrinker Awaiting requested review from alilleybrinker

Assignees

@mchernicoff mchernicoff

Labels
type: bug Something isn't working
Projects
No open projects
Hipcheck Dev Roadmap
Status: Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mchernicoff @j-lanson