Add cargo xtask rfd subcommand with convenience methods for interacting with RFDs.
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CLI for listing RFDs. Next I'll be adding the ability to initiate new ones. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This adds a command to create a new RFD, and also refactors the existing `cargo xtask rfd list` command to use a new `RfdIter` type which provides a convenient API for iterating over RFDs. Signed-off-by: Andrew Lilley Brinker <[email protected]>
mchernicoff
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this PR adds a new
cargo xtask rfdcommand with two subcommands:cargo xtask rfd list: List all merged RFDs.cargo xtask rfd new: Create a new, draft RFD.These are basic conveniences now, but in the future I'd love to do more to, for example, use the GitHub API to link to and open RFDs which are under consideration.