feat: Creates a single analysis crate that handles most of the Hipcheck analysis pipeline #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as a draft for now because more testing may be needed to make sure these changes do not break Hipcheck. |
|
I know it's still a draft, but I'm reviewing now! |
alilleybrinker
approved these changes
May 3, 2024
|
LGTM! Tested locally and everything ran without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the code from the below crates into a single
hc_analysiscrate:hc_analysishc_metrichc_scorehc_sessionhc_report_builderThe idea is that most of the code thar starts a Hipcheck session, calculates metrics, analyzes metrics, scores analysis, and constructs a final report will all be inside a single crate.