Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds structures and functions to parse policy files. #330

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mchernicoff
Copy link
Contributor

Partially resolves #329

Adds data structures and functions to parse a policy file in KDL format.

The parsed policy file is currently not used by Hipcheck, and Hipcheck still needs a Config.toml file to run.

@mchernicoff mchernicoff added the type: enhancement New feature or request label Sep 4, 2024
@mchernicoff mchernicoff added this to the 3.6.0 milestone Sep 4, 2024
@mchernicoff mchernicoff requested a review from a team September 4, 2024 17:50
@mchernicoff mchernicoff self-assigned this Sep 4, 2024
@mchernicoff mchernicoff requested review from j-lanson and removed request for a team September 4, 2024 17:50
@mchernicoff mchernicoff force-pushed the mchernicoff/parse-policy branch 2 times, most recently from 8ff6428 to 3713db0 Compare September 4, 2024 17:54
@mchernicoff
Copy link
Contributor Author

mchernicoff commented Sep 4, 2024

Tests are working locally. Will figure out why its failing in CI. (Update: Looks like I have some unused functions that were not caught for some reason).

Update 2: Allowing dead code for functions we intend to use in the future.

@mchernicoff mchernicoff force-pushed the mchernicoff/parse-policy branch from 3713db0 to c94f992 Compare September 4, 2024 18:22
@alilleybrinker alilleybrinker merged commit db4a465 into main Sep 4, 2024
9 checks passed
@mchernicoff mchernicoff deleted the mchernicoff/parse-policy branch September 5, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement policy file parsing
2 participants